Skip to content

OCPBUGS-62422: staticpod/prune: Remove tmp cert file pruning #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

OCPBUGS-62422: staticpod/prune: Remove tmp cert file pruning #2053

wants to merge 2 commits into from
+10 −55

Conversation

@tchap
Copy link
Contributor

@tchap tchap commented Nov 18, 2025

This is no longer needed as pruning happens in relevant sync looks that actually write these certificates atomically.

@tchap
staticpod/prune: Remove tmp cert file pruning
c9f261a 
This is no longer needed as pruning happens in relevant sync looks that
actually write these certificates atomically.
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 18, 2025

@tchap: This pull request references Jira Issue OCPBUGS-62422, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is no longer needed as pruning happens in relevant sync looks that actually write these certificates atomically.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tchap
Once this PR has been reviewed and has the lgtm label, please assign tkashem for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tchap
Copy link
Contributor Author

tchap commented Nov 18, 2025

I am marking this as

/hold

to actually test this somewhere.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2025
@tchap
Copy link
Contributor Author

tchap commented Nov 18, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 18, 2025

@tchap: This pull request references Jira Issue OCPBUGS-62422, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from wangke19 November 18, 2025 23:58
@tchap tchap mentioned this pull request Nov 19, 2025
Open
@tchap
staticpod/prune: Remove certDir argument
36add39 
This is no longer needed as prune does not prune any certs.
tchap
tchap commented Nov 20, 2025
View reviewed changes
pkg/operator/staticpod/controller/prune/prune_controller.go
func NewPruneController(
targetNamespace string,
podResourcePrefix string,
certDir string,
Copy link
Contributor Author

@tchap tchap Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed, but it also breaks the API 🤷🏻‍♂️

@tchap
Copy link
Contributor Author

tchap commented Nov 20, 2025

Well, I am not sure extra testing is worth it as we are only removing stuff. The WIP PR I created only contains Nothing to prune log entries.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

@tchap: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tchap @openshift-ci-robot